Move real/integer bounds attributes to properties #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoto-moniz
reviewed
Jan 10, 2024
anoto-moniz
previously approved these changes
Jan 10, 2024
Contributor
anoto-moniz
left a comment
anoto-moniz
left a comment
There was a problem hiding this comment.
Only comment is the one about unnecessary ordering, but it only impacts us, it's not a big deal if you wanna ignore it.
anoto-moniz
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the lower_bound and upper_bound attributes of IntegerBounds and RealBounds objects to properties, creating getters & setters and locating validation code in those subroutines. It also moves responsibility for verifying that required positional arguments were passed from an explicit default argument check to the compiler.
Technically breaking, since it migrates what was formerly a ValueError to a TypeError and adds setter constraints that were previously bypassed if the user modified objects. Such objects were already considered invalid by Citrine Platform.
This should represent no meaningful change in behavior.