Update resource import strategy to resolve deprecation warnings #213
+24
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mVenetos97
reviewed
Apr 3, 2024
| resource = read_binary("gemd.demo", "toothpick.jpg") | ||
|
|
||
| return BytesIO(resource) | ||
| return files("gemd.demo").joinpath("toothpick.jpg").open("rb") |
There was a problem hiding this comment.
Should we rewrite this to files("gemd.demo").joinpath("toothpick.jpg").read_bytes() to be consistent with strehlow_and_cook.py and test_parser.py?
Collaborator
Author
There was a problem hiding this comment.
It'd be nice, but that would break downstream consumers that expect a byte stream instead of bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importlib has deprecated several methods in favor of methods that are not available in Python 3.8. This PR imports their third-party re-implementations to maintain 3.8 support while resolving the warnings for 3.12 in this and downstream libraries.