Skip to content

Conversation

@xperrylinn
Copy link
Contributor

@xperrylinn xperrylinn commented Jul 23, 2024

Adding Mooney to base units

GEMD Python PR

Description

Please briefly explain the goal of the changes/this PR.
The reviewer should be able to understand why the change is being made by reading this description
and its links (e.g. JIRA tickets).

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@xperrylinn xperrylinn requested a review from kroenlein July 23, 2024 19:22
Copy link
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we're not adding a conversion into another class of viscosity, Pint would behave well if the basis were []. However, in case some other tool assume that equivalent basis means interoperable, I'm conservatively leaving the non-empty basis string.

@kroenlein kroenlein self-assigned this Jul 29, 2024
Co-authored-by: Ken Kroenlein <51962276+kroenlein@users.noreply.github.com>
Copy link
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kroenlein kroenlein merged commit f3be77f into main Jul 29, 2024
@kroenlein kroenlein deleted the xperrylinn-patch-1 branch July 29, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants