Skip to content

Conversation

@kroenlein
Copy link
Collaborator

GEMD Python PR

Description

This PR updates the units file to be consistent with the Pint 0.23 release, which includes support for percent & ppm. This also requires bumping Pint minimum version to 0.21 in order to support parsing the % symbol. This does not impact the minimum supported version of Python.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@kroenlein kroenlein requested a review from anoto-moniz July 31, 2024 22:53
Copy link
Contributor

@anoto-moniz anoto-moniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kroenlein kroenlein merged commit 57827c0 into main Aug 1, 2024
@kroenlein kroenlein deleted the feature/percent branch August 1, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants