Skip to content

Conversation

@waffle-stomper
Copy link

Maester Flaminius has asked me to add these recipes to the printing press. I'll work on the more advanced features once I've wrapped my head around them.

@CivcraftBot
Copy link

Can one of the admins verify this patch? Type 'ok to test' to test.

amount: 18
output:
books:
material: BOOK

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will produce empty, possibly unusable (due to missing nbt) written books, so kinda pointless

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. It seems to produce these books as intended when I run it on my test server. I can successfully use them to create bookshelves and book & quill books, and they refuse to open with a right click.

I thought written books were org.bukkit.Material.WRITTEN_BOOK?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait yeah, I havent played minecraft for too long. Nevermind.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should get back into it - it's a lot of fun, (if a bit of a time sink). There's this great server called Civcraft you should definitely check out.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so is this patch good and not broken?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so. Should we just merge this and then merge it into gitlab or do the PR there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I submit this to the wrong FactoryMod repo? If so, sorry!

@Maxopoly Maxopoly merged commit 1bcc0fb into Civcraft:master Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants