Allow registering event listening methods with illegal param type #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mods (e.g. CompatUtil in RLTweaker) will intentionally call private
registermethod to register their event listener, even when the param type is illegal.This PR fixed this "issue" by making
EventListenerFactorygenerateConsumer<Event>instead ofIEventListener, because the functional method inConsumerisvoid accept(T t);, whose param type class isObjectinstead ofEvent.Registering event listener in this way is, in my opinion, really stupid and far from best practice, especially when you can just create a new class with legal param type, and prevent loading non-existent event classes by simply not using such class: