Skip to content

Conversation

@WaitingIdly
Copy link
Collaborator

changes in this PR:

  • create a common StyleConstant class for unifying formatting between various places for nbt, messages, info commands, and other things printed to chat. contains both TextFormatting and
  • make withNbt colored.
  • make Click to copy end with a colon :.
  • make a lot of instances in which TextFormatting.* + "" was done be converted into using setStyle instead.
  • fix Mekanism infusionTypes command logging just the names instead of the GroovyScript code to get the type
  • fix InfoParserOreDict having the incorrect text be copied.
  • fix JEI InfoParserTab not getting tabs if the catalyst stack size was different than expected.
  • extract InfoParserNBT magic numbers to be extracted to constants.
  • make NBT data letter types be lowercase f.x. F -> f.
  • adjust colors used and ensure consistency.

@WaitingIdly WaitingIdly added bug Something isn't working refactor Something is rewritten labels Oct 13, 2024
# Conflicts:
#	src/main/java/com/cleanroommc/groovyscript/GroovyScript.java
#	src/main/java/com/cleanroommc/groovyscript/command/GSCommand.java
#	src/main/java/com/cleanroommc/groovyscript/core/mixin/groovy/ModuleNodeMixin.java
@brachy84 brachy84 merged commit d690ed6 into CleanroomMC:master Nov 8, 2024
@WaitingIdly WaitingIdly deleted the color-constants branch November 8, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working refactor Something is rewritten

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants