Skip to content

Fix file sorting when previously matched #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brachy84 merged 3 commits into from
Nov 8, 2024
Merged

Fix file sorting when previously matched #261

brachy84 merged 3 commits into from
Nov 8, 2024

Conversation

@WaitingIdly
Copy link
Collaborator

@WaitingIdly WaitingIdly commented Oct 13, 2024

changes in this PR:

  • change SandboxData#getSortedFilesOf to use putAndMoveToLast instead of just put so the order of files is changed correctly.
  • add comments to make it easier to understand
  • use StringUtils match instead of split length

@WaitingIdly WaitingIdly added the bug Something isn't working label Oct 13, 2024
@WaitingIdly
Merge branch 'master' into walk-files-order
49fa5ed 
# Conflicts:
#	src/main/java/com/cleanroommc/groovyscript/sandbox/SandboxData.java
@brachy84 brachy84 merged commit c3d8582 into CleanroomMC:master Nov 8, 2024
@WaitingIdly WaitingIdly deleted the walk-files-order branch November 8, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WaitingIdly @brachy84