Fallback property container for all installed mods #289
Conversation
WaitingIdly
left a comment
WaitingIdly
left a comment
There was a problem hiding this comment.
a likely unexpected side effect of this is mods.minecraft now exists. i think this is the correct behavior, it just becomes a bit weird to speak of.
due to this, though, it makes sense to bind the currently existing vanilla compat to mods.minecraft - and bind the custom original groovyscript to mods.groovyscript.
additionally, it seems like it would make sense to add compat as an alias to mods (ie compat.minecraft).
src/main/java/com/cleanroommc/groovyscript/compat/mods/ModSupport.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/helper/GroovyHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/mods/BasicGroovyPropertyContainer.java
Outdated
Show resolved
Hide resolved
…edient, improvements
# Conflicts: # src/main/java/com/cleanroommc/groovyscript/helper/ingredient/OreDictIngredient.java
| return t; | ||
| }); | ||
| Set<String> aliasSet = new ObjectOpenHashSet<>(); | ||
| aliasSet.add("mc"); |
There was a problem hiding this comment.
would vanilla be a good alias? would allow mods.vanilla, which i find rather amusing.
i believe using aliasSet.addAll(Alias.generateOf("Vanilla", containerName).and("MC", "mc")); should work.
| private final String modId = "minecraft"; | ||
| private final String containerName = "Minecraft"; |
There was a problem hiding this comment.
is there a reason not to have these be static?
You now access all installed mods with
mods.[modid]. There are basic getters for id, name, version and forge mod container.mods.[modid].allItemsreturns aIIngredientwith all items from that mod (which are exposed to the creative inventory).Supersedes #275