Skip to content

Conversation

@brachy84
Copy link
Member

@brachy84 brachy84 commented Apr 1, 2025

There was an issue where classes on reload can randomly not be found without any consistent reproducability.
In an attempt to fix this a custom GroovyScriptEngine and GroovyClassLoader has been implemented in this pr.
Both of these classes had their own caching mechanic which might have clashed in some way. This caching is now removed.

  • The script caching from GroovyScriptSandox moved to CustomGroovyScriptEngine
  • GroovySandbox class is removed as abstraction doesnt make sense here
  • GroovyScript now handles script dependencies properly: When a script references another script, its automatically loaded
  • classes are no longer special cases in the run config
  • since script deps are auto loaded, classes only need to be specified if they contain any static code that needs to run
  • the custom impl also allows removing 2 mixin classes

@brachy84 brachy84 merged commit 588f22f into master Apr 2, 2025
@brachy84 brachy84 deleted the fix/classes branch April 13, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants