generated from CleanroomMC/ForgeDevEnv
-
Notifications
You must be signed in to change notification settings - Fork 30
Document via Descriptor and adjust Recipe Builder #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brachy84
merged 33 commits into
CleanroomMC:master
from
WaitingIdly:document-method-via-descriptor
May 5, 2025
Merged
Document via Descriptor and adjust Recipe Builder #302
brachy84
merged 33 commits into
CleanroomMC:master
from
WaitingIdly:document-method-via-descriptor
May 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
approved these changes
May 5, 2025
Member
brachy84
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
significant changes:
INamedregistry missing annotation).changes in this PR:
@MethodOverrideand@RecipeBuilderOverrideannotations.methodto@MethodDescription,@RecipeBuilderDescription,@RecipeBuilderMethodDescription, and@RecipeBuilderRegistrationMethodto support being used in these overrides.@MethodOverridecan contain any number of@MethodDescriptionand@RecipeBuilderDescriptionannotations, but they must definemethod.@RecipeBuilderOverridecan contain any number of@RecipeBuilderMethodDescriptionand@RecipeBuilderRegistrationMethodannotations, but they must definemethod. Further, it can contain any number of@Propertyannotations.RecipeBuilderDescription#requirementin favor of usingRecipeBuilderOverride#requirement@RecipeBuilderDescriptionannotation also gained the ability to specify the return value of the class viaRecipeBuilderDescription#clazz.mods.actuallyadditions.crusher.recipeBuilder()) toRecipe Builder, with the ability to be customized viaRecipeBuilderDescription#titleor via a default lang key (groovyscript.wiki.{modId}.{name}.{methodName}.title).mods.actuallyadditions.crusher.recipeBuilder()goes. Add a default description ofCreate the Recipe Builder, but as before this can be customized viaRecipeBuilderDescription#descriptionor via a default lang key (groovyscript.wiki.{modId}.{name}.{methodName}.description).recipeBuilder.(, all others require starting with..DescriptorHelperto handle string->method targeting and a handful of previously scattered methods.ComparisonHelperto handle sorting of various things - primarily annotations.LangHelperto handle translations and punctuation.GenerationFlagsto handle reading system properties.outputmethod to point toprobabilityGroup, and incorrectly markingoutputas being used.durationas pointing toticks./, solving an annoying common issue of "author forgot it".IFormatand instead referencing static constant in some places.StringBufferMayBeStringBuilderdue to it being an invalid warning for the java version we use.@RegistryDescriptionannotation.defaultValueConverternot incorrect regarding primitive wrapper classes. Further, change longs to use0L.---) between segments of the recipe builder admonition.