feat: Add author field to RunConfig #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
requested changes
May 21, 2025
Member
brachy84
left a comment
brachy84
left a comment
There was a problem hiding this comment.
Please revert the other changes in runConfig
WaitingIdly
reviewed
May 21, 2025
| { | ||
| "packName": "GroovyScript Dev", | ||
| "packId": "groovyscriptdev", | ||
| "author": "GroovyScript, Dev, Author", |
Collaborator
There was a problem hiding this comment.
should be an array - ["GroovyScript", "Dev", "Author"]
Contributor
Author
There was a problem hiding this comment.
No, I would like to see it as a regular string, and then inside it is parsed as needed for modMetadata, like the curseforge manifest, pakku
Collaborator
There was a problem hiding this comment.
thats CurseForge's format - for mods, in the mcmod.info the relevant element is authorList, an array. this is creating a mod, and so it should be an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: