Skip to content

Improve VanillaModule design #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brachy84 merged 7 commits into from
Sep 27, 2025
Merged

Improve VanillaModule design #324

brachy84 merged 7 commits into from
Sep 27, 2025

Conversation

@WaitingIdly
Copy link
Collaborator

@WaitingIdly WaitingIdly commented Aug 28, 2025

changes in this PR:

  • make the currently static property fields of VanillaModule non-static.
  • convert the properties added as global bindings to a list.
  • remove some global bindings - specifically player, loot, rarity, command, and gameRule.
  • create a way to add additional properties to the VanillaModule, include a shorthand way to make it a global binding (relevant for mods that add functionality involving vanilla features).

@WaitingIdly WaitingIdly added the enhancement New feature or request label Aug 28, 2025
@brachy84 brachy84 merged commit 949abda into CleanroomMC:master Sep 27, 2025
@WaitingIdly WaitingIdly deleted the vanilla-module branch September 27, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WaitingIdly @brachy84