generated from CleanroomMC/ForgeDevEnv
-
Notifications
You must be signed in to change notification settings - Fork 30
Enhanced Furnace Compat #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brachy84
merged 15 commits into
CleanroomMC:master
from
WaitingIdly:furnace-improvements
Oct 6, 2025
Merged
Enhanced Furnace Compat #331
brachy84
merged 15 commits into
CleanroomMC:master
from
WaitingIdly:furnace-improvements
Oct 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
requested changes
Sep 27, 2025
src/main/java/com/cleanroommc/groovyscript/helper/ingredient/ItemStackHashStrategy.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/compat/vanilla/Furnace.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/com/cleanroommc/groovyscript/compat/vanilla/Furnace.java
brachy84
requested changes
Oct 5, 2025
src/main/java/com/cleanroommc/groovyscript/helper/ingredient/ItemStackHashStrategy.java
Outdated
Show resolved
Hide resolved
brachy84
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
FurnaceRecipeManagerfieldinputMapintoINPUT_SET(constant-case + the object is a set).timevalue of an itemstack and compat viafurnace.furnace. this mixin also causes it to skip the standard logic ofwet sponge+bucket->water bucketand uses a custom list containing that logic instead.FurnaceRecipeManagerto its own class in ingredient/helper.experienceas an alias method forexpfor the furnace recipe builder.