Skip to content

Remove unneeded SimpleObjectStream copying #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brachy84 merged 1 commit into from
Oct 10, 2025
Merged

Remove unneeded SimpleObjectStream copying #345

brachy84 merged 1 commit into from
Oct 10, 2025

Conversation

@WaitingIdly
Copy link
Collaborator

@WaitingIdly WaitingIdly commented Oct 10, 2025

changes in this PR:

  • if we just created a list, we dont need to copy it for the SOS. prior to this PR, not copying the list was used in only two places - now its used in 33.

@brachy84 brachy84 merged commit 15d8817 into CleanroomMC:master Oct 10, 2025
@WaitingIdly WaitingIdly deleted the stream-uncopy branch October 12, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WaitingIdly @brachy84