Skip to content

Allow digits in pack id #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brachy84 merged 1 commit into from
Nov 26, 2025
Merged

Allow digits in pack id #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/com/cleanroommc/groovyscript/sandbox/RunConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ public static JsonObject createDefaultJson() {
private final String asmClass = null;
private boolean debug;


private final boolean invalidPackId;
private boolean warnedAboutInvalidPackId;
private int packmodeConfigState;

public static final String[] GROOVY_SUFFIXES = SandboxData.GROOVY_SUFFIXES;
private static final Pattern ID_PATTERN = Pattern.compile("[a-z0-9_]+");

public static boolean isGroovyFile(String path) {
return SandboxData.isGroovyFile(path);
Expand All @@ -88,8 +88,7 @@ public static boolean isGroovyFile(String path) {
public RunConfig(JsonObject json) {
String name = JsonHelper.getString(json, "", "packName", "name");
String id = JsonHelper.getString(json, "", "packId", "id");
Pattern idPattern = Pattern.compile("[a-z_]+");
this.invalidPackId = id.isEmpty() || !idPattern.matcher(id).matches();
this.invalidPackId = id.isEmpty() || !ID_PATTERN.matcher(id).matches();
if (name.isEmpty() && !this.invalidPackId) {
name = CaseFormat.LOWER_UNDERSCORE.to(CaseFormat.UPPER_CAMEL, id).replace('_', ' ');
}
Expand Down