generated from CleanroomMC/ForgeDevEnv
-
Notifications
You must be signed in to change notification settings - Fork 30
Enhance docgen for overriding default logic #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/com/cleanroommc/groovyscript/documentation/Exporter.java
brachy84
approved these changes
Dec 10, 2025
Member
brachy84
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine i think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
VALUEgenerate before everything else.{stage}/generatedand rename them to{id}_generated.groovy.log.infoto justlogplaceholdernamebeing used instead ofgroovyscriptdev.tulptotulip.[by a single space in some situations so it aligns better.@RegistryDescription#locationuseLoadStageinstead of a name.Category.CUSTOMwhich reads from lang keys instead (+will generate warnings if lang keys are missing) for custom categories on the wiki.ContainerHolderto hold a lot of the logic and allow customization.HeadingandLinkIndexto help generate markdown index files easier.setFillSoundandsetEmptySoundtoGroovyFluidinstead ofsetSound(SoundEvent, SoundEvent), andisFiniteto modifyfiniteFluidBlock(was previously unmodifiable).PistonPushcheck fromthis.maxConversionsPerPush < 0tothis.maxConversionsPerPush <= 0, since0is also invalidEmpowerer#color(float...)tocolor(float, float, float)and removeif (length != 3) warn!. also replace the awt color class with direct bitwise operations.Chisel#setSoundfromVALUEtoADDITION.MeltingRecipeBuildernot being a valid builder (when callingtimetried to accessfluidOutput).