Skip to content

Conversation

@filimonov
Copy link
Contributor

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix tiny mistake, responsible for some of kafka test flaps. Example report

Introduced c0eea71 cc. @antaljanosbenjamin

There is also another issue with Kafka tests - It can be caused by some resource limits (OOM?) or smth similar #68360 example report,

[gw0] [ 98%] ERROR test_storage_kafka/test.py::test_system_kafka_consumers 
test_storage_kafka/test.py::test_system_kafka_consumers_rebalance Killed

@antaljanosbenjamin antaljanosbenjamin self-assigned this Oct 4, 2024
@antaljanosbenjamin antaljanosbenjamin added the can be tested Allows running workflows for external contributors label Oct 4, 2024
@antaljanosbenjamin
Copy link
Member

Wow, rookie mistake from me. Thanks for fixing it!

@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Oct 4, 2024

This is an automated comment for commit 1871de3 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antaljanosbenjamin
Copy link
Member

test_ldap_external_user_directory/test.py::test_authentication_pass is flaky

@antaljanosbenjamin antaljanosbenjamin added this pull request to the merge queue Oct 4, 2024
@antaljanosbenjamin antaljanosbenjamin added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 4, 2024
Merged via the queue into ClickHouse:master with commit c07f2b7 Oct 4, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 4, 2024
robot-clickhouse added a commit that referenced this pull request Oct 4, 2024
robot-clickhouse added a commit that referenced this pull request Oct 4, 2024
robot-clickhouse-ci-1 added a commit that referenced this pull request Oct 4, 2024
robot-clickhouse-ci-2 added a commit that referenced this pull request Oct 4, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created-cloud deprecated label, NOOP label Oct 10, 2024
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-ci pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants