-
Notifications
You must be signed in to change notification settings - Fork 8k
fix Kafka test #70352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
antaljanosbenjamin
merged 1 commit into
ClickHouse:master
from
filimonov:maybe_fix_kafka
Oct 4, 2024
Merged
fix Kafka test #70352
antaljanosbenjamin
merged 1 commit into
ClickHouse:master
from
filimonov:maybe_fix_kafka
Oct 4, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wow, rookie mistake from me. Thanks for fixing it! |
antaljanosbenjamin
approved these changes
Oct 4, 2024
Contributor
|
This is an automated comment for commit 1871de3 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
Member
|
|
This was referenced Oct 4, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Oct 4, 2024
This was referenced Oct 4, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Oct 4, 2024
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
Oct 4, 2024
Backport #70352 to 24.8: fix Kafka test
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Oct 4, 2024
Backport #70352 to 24.9: fix Kafka test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
deprecated label, NOOP
pr-ci
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix tiny mistake, responsible for some of kafka test flaps. Example report
Introduced c0eea71 cc. @antaljanosbenjamin
There is also another issue with Kafka tests - It can be caused by some resource limits (OOM?) or smth similar #68360 example report,