Skip to content

Conversation

@Avogar
Copy link
Member

@Avogar Avogar commented Nov 19, 2025

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix possible logical error in prewhere on non-existing JSON path with index_granularity_bytes=0. Resolves #86924

@rienath rienath self-assigned this Nov 19, 2025
@clickhouse-gh
Copy link

clickhouse-gh bot commented Nov 19, 2025

Workflow [PR], commit [90a6e4b]

Summary:

job_name test_name status info comment
Build (amd_compat) failure
Cmake configuration failure cidb
Integration tests (arm_binary, distributed plan, 2/4) failure
test_refreshable_mv/test.py::test_refreshable_mv_in_read_only_node_no_ddl FAIL cidb
test_refreshable_mv/test.py::test_refresh_vs_shutdown_smoke FAIL cidb
test_refreshable_mv/test.py::test_pause FAIL cidb
test_refreshable_mv/test.py::test_backup_outer_table FAIL cidb, flaky
test_refreshable_mv/test.py::test_backup_inner_table FAIL cidb
test_refreshable_mv/test.py::test_adding_replica FAIL cidb
test_refreshable_mv/test.py::test_replicated_db_startup_race FAIL cidb
Integration tests (amd_tsan, 1/6) failure
test_storage_s3_queue/test_parallel_inserts.py::test_parallel_inserts_with_failures[1] FAIL cidb, flaky
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: FAIL cidb

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Nov 19, 2025
Copy link
Member

@rienath rienath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once we address the CI warning, we should be ready to merge

@Avogar
Copy link
Member Author

Avogar commented Nov 21, 2025

@Avogar Avogar added this pull request to the merge queue Nov 21, 2025
Merged via the queue into ClickHouse:master with commit 6d5ad13 Nov 21, 2025
127 of 132 checks passed
@Avogar Avogar deleted the fix-prewhere-json-subcolumn branch November 21, 2025 17:03
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 21, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Nov 21, 2025
robot-ch-test-poll2 added a commit that referenced this pull request Nov 21, 2025
Cherry pick #90375 to 25.8: Fix prewhere on non-existing JSON path with index_granularity_bytes=0
robot-clickhouse added a commit that referenced this pull request Nov 21, 2025
robot-ch-test-poll2 added a commit that referenced this pull request Nov 21, 2025
Cherry pick #90375 to 25.9: Fix prewhere on non-existing JSON path with index_granularity_bytes=0
robot-clickhouse added a commit that referenced this pull request Nov 21, 2025
robot-ch-test-poll2 added a commit that referenced this pull request Nov 21, 2025
Cherry pick #90375 to 25.10: Fix prewhere on non-existing JSON path with index_granularity_bytes=0
robot-clickhouse added a commit that referenced this pull request Nov 21, 2025
robot-ch-test-poll2 added a commit that referenced this pull request Nov 21, 2025
Cherry pick #90375 to 25.11: Fix prewhere on non-existing JSON path with index_granularity_bytes=0
robot-clickhouse added a commit that referenced this pull request Nov 21, 2025
clickhouse-gh bot added a commit that referenced this pull request Nov 21, 2025
Backport #90375 to 25.11: Fix prewhere on non-existing JSON path with index_granularity_bytes=0
clickhouse-gh bot added a commit that referenced this pull request Nov 21, 2025
Backport #90375 to 25.8: Fix prewhere on non-existing JSON path with index_granularity_bytes=0
rienath added a commit that referenced this pull request Nov 24, 2025
Backport #90375 to 25.10: Fix prewhere on non-existing JSON path with index_granularity_bytes=0
rienath added a commit that referenced this pull request Nov 24, 2025
Backport #90375 to 25.9: Fix prewhere on non-existing JSON path with index_granularity_bytes=0
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RangeReader read 2 rows, but 65536 expected: While executing MergeTreeSelect(pool: ReadPool, algorithm: Thread).

5 participants