Operation (Query) Metrics #1633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3 tasks
mzitnik
approved these changes
May 21, 2024
| } | ||
|
|
||
| public void start() { | ||
| startNanoTime = System.nanoTime(); |
Contributor
There was a problem hiding this comment.
from what i remember nano time is more expensive https://www.tutorialspoint.com/java-system-nanotime-vs-system-currenttimemillis
Contributor
Author
There was a problem hiding this comment.
I've found some good doc from JDK developer https://web.archive.org/web/20160308031939/https://blogs.oracle.com/dholmes/entry/inside_the_hotspot_vm_clocks
It explains why nanoTime() may be slow and what should be used for precise measurement.
Conclusion:
- nanoTime() may be slow in scale of microseconds
- nanoTime() may require hardware IO and that is why it may be slow
- nanoTime() is what recommended for elapsed time measurements.
- currentTimeMillis() is not so precise and may have a lag of 10ms
- we will use nanoTime() until we see a noticeable drop in performance.
| private static final String INTERNAL_OPERATION_ID = "operationID"; | ||
|
|
||
| private String startOperation() { | ||
| String operationId = UUID.randomUUID().toString(); |
Contributor
There was a problem hiding this comment.
Are we sending operationId also as query_id this can be a good connection between our code and the actual operation in ClickHouse
thalinda-oss
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds class to represent metrics of an operation.
Checklist
Delete items not relevant to your PR: