Conversation
chernser
reviewed
Jan 2, 2025
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Outdated
Show resolved
Hide resolved
chernser
reviewed
Jan 2, 2025
| this.metaData = new com.clickhouse.jdbc.metadata.ResultSetMetaData(this); | ||
| this.closed = false; | ||
| this.wasNull = false; | ||
| this.defaultCalendar = new GregorianCalendar(TimeZone.getTimeZone("UTC")); |
Contributor
There was a problem hiding this comment.
there is a feature to use server timezone for date. So it may be applicable here.
Contributor
Author
There was a problem hiding this comment.
I will check the JDBC v1 implementation to how we deal with that in the past
chernser
approved these changes
Jan 2, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tableau fix getDate with calendar
Checklist
Delete items not relevant to your PR: