Skip to content

[client-v2] Fix not passing query parameter #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chernser merged 1 commit into from
Jun 9, 2025
Merged

[client-v2] Fix not passing query parameter #2438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions client-v2/src/main/java/com/clickhouse/client/api/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1671,8 +1671,8 @@ public List<GenericRecord> queryAll(String sqlQuery, Map<String, Object> params,
int operationTimeout = getOperationTimeout();
settings.setFormat(ClickHouseFormat.RowBinaryWithNamesAndTypes)
.waitEndOfQuery(true);
try (QueryResponse response = operationTimeout == 0 ? query(sqlQuery, params, settings).get() :
query(sqlQuery, settings).get(operationTimeout, TimeUnit.MILLISECONDS)) {
CompletableFuture<QueryResponse> f = query(sqlQuery, params, settings);
try (QueryResponse response = operationTimeout == 0 ? f.get() : f.get(operationTimeout, TimeUnit.MILLISECONDS)) {
List<GenericRecord> records = new ArrayList<>();
if (response.getResultRows() > 0) {
RowBinaryWithNamesAndTypesFormatReader reader =
Expand Down Expand Up @@ -1738,8 +1738,8 @@ public <T> List<T> queryAll(String sqlQuery, Class<T> clazz, TableSchema schema,
try {
int operationTimeout = getOperationTimeout();
QuerySettings settings = new QuerySettings().setFormat(ClickHouseFormat.RowBinaryWithNamesAndTypes);
try (QueryResponse response = operationTimeout == 0 ? query(sqlQuery, settings).get() :
query(sqlQuery, settings).get(operationTimeout, TimeUnit.MILLISECONDS)) {
CompletableFuture<QueryResponse> f = query(sqlQuery, settings);
try (QueryResponse response = operationTimeout == 0 ? f.get() : f.get(operationTimeout, TimeUnit.MILLISECONDS)) {
List<T> records = new ArrayList<>();
RowBinaryWithNamesAndTypesFormatReader reader =
(RowBinaryWithNamesAndTypesFormatReader) newBinaryFormatReader(response);
Expand Down
Loading