Skip to content

Conversation

@dolfinus
Copy link
Contributor

@dolfinus dolfinus commented Oct 30, 2025

Summary

Java 8 doesn't have List.of() method:

: java.lang.NoSuchMethodError: java.util.List.of(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)Ljava/util/List;
        at com.clickhouse.jdbc.DriverProperties.<clinit>(DriverProperties.java:69)
        at com.clickhouse.jdbc.internal.JdbcConfiguration.initProperties(JdbcConfiguration.java:269)
        at com.clickhouse.jdbc.internal.JdbcConfiguration.<init>(JdbcConfiguration.java:74)
        at com.clickhouse.jdbc.ConnectionImpl.<init>(ConnectionImpl.java:76)
        at com.clickhouse.jdbc.Driver.connect(Driver.java:109)
        at com.clickhouse.jdbc.ClickHouseDriver.connect(ClickHouseDriver.java:96)
        at org.apache.spark.sql.execution.datasources.jdbc.DriverWrapper.connect(DriverWrapper.scala:46)
        at java.sql.DriverManager.getConnection(DriverManager.java:664)
        at java.sql.DriverManager.getConnection(DriverManager.java:208)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
        at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:374)
        at py4j.Gateway.invoke(Gateway.java:282)
        at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
        at py4j.commands.CallCommand.execute(CallCommand.java:79)
        at py4j.ClientServerConnection.waitForCommands(ClientServerConnection.java:182)
        at py4j.ClientServerConnection.run(ClientServerConnection.java:106)
        at java.lang.Thread.run(Thread.java:750)

This was introduced in #2579

Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@chernser
Copy link
Contributor

Thank you for catching it!

This is would be caught while release phase - as we make sure libraries work with jdk 8

@chernser chernser merged commit 75b432c into ClickHouse:main Oct 30, 2025
33 of 39 checks passed
@dolfinus dolfinus deleted the bugfix/java-compat branch October 30, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants