Skip to content

Jdbc impl get result set in array #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chernser merged 18 commits into from
Dec 10, 2025

fixed boundary check for index column

c6c2f85
Select commit
Loading
Failed to load commit list.
Merged

Jdbc impl get result set in array #2668

fixed boundary check for index column
c6c2f85
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Dec 9, 2025 in 1m 33s

Quality Gate failed

Failed conditions
45.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 427 in jdbc-v2/src/test/java/com/clickhouse/jdbc/ResultSetImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ClickHouseVersion"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZrxWsidFDjduF-g7WK_&open=AZrxWsidFDjduF-g7WK_&pullRequest=2668

Check warning on line 9 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/ValueConverters.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.sql.Date'. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZsEUhTft_USNwnROV7-&open=AZsEUhTft_USNwnROV7-&pullRequest=2668

Check warning on line 171 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/ValueConverters.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZsAekS40SV6MOQ7n92K&open=AZsAekS40SV6MOQ7n92K&pullRequest=2668

Check warning on line 227 in jdbc-v2/src/main/java/com/clickhouse/jdbc/types/ArrayResultSet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to "float". 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZq9GifItl8i2EI0gkA8&open=AZq9GifItl8i2EI0gkA8&pullRequest=2668

Check failure on line 393 in jdbc-v2/src/main/java/com/clickhouse/jdbc/types/ArrayResultSet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZq9GifItl8i2EI0gj_n&open=AZq9GifItl8i2EI0gj_n&pullRequest=2668

Check failure on line 462 in jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/JdbcUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZrxWsjGFDjduF-g7WLA&open=AZrxWsjGFDjduF-g7WLA&pullRequest=2668

Check warning on line 123 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/ValueConverters.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZrr6QT0EAUtN0e-6mGn&open=AZrr6QT0EAUtN0e-6mGn&pullRequest=2668

Check warning on line 114 in jdbc-v2/src/main/java/com/clickhouse/jdbc/types/ArrayResultSet.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to use the more specialised Functional Interface 'UnaryOperator<Object>' 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZsEcrUjY1jcaP2Vat1n&open=AZsEcrUjY1jcaP2Vat1n&pullRequest=2668
View more details on SonarQubeCloud