[client-v2,jdbc-v2] Fix reading Date/Time values #2727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be stored as Integer
…is reduces number of conversions and makes logic simple
… dates are used for simpler reference
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
chernser
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Outdated
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
…ime value and actual time from it
chernser
commented
Feb 1, 2026
| return getString(schema.columnIndexToName(index)); | ||
| ClickHouseColumn column = schema.getColumnByIndex(index); | ||
| Object value; | ||
| switch (column.getEffectiveDataType()) { |
Contributor
Author
There was a problem hiding this comment.
each type better represented by different type
chernser
commented
Feb 1, 2026
| if (converter != null) { | ||
| Object value = readValue(colName); | ||
| if (value == null) { | ||
| if (targetType == NumberConverter.NumberType.BigInteger || targetType == NumberConverter.NumberType.BigDecimal) { |
Contributor
Author
There was a problem hiding this comment.
BigInteger and BigDecimal are object type so they fine with null.
in the next steps we will move it to converter so this check also go away.
chernser
commented
Feb 1, 2026
| default: | ||
| throw new ClientException("Column of type " + column.getDataType() + " cannot be converted to Instant"); | ||
| } | ||
| return getInstant(getSchema().nameToColumnIndex(colName)); |
Contributor
Author
There was a problem hiding this comment.
getting columns by index is more common and values also stored in simple array
chernser
commented
Feb 1, 2026
| public ZonedDateTime getZonedDateTime(int index) { | ||
| return readValue(index); | ||
| ClickHouseColumn column = schema.getColumnByIndex(index); | ||
| switch (column.getEffectiveDataType()) { |
Contributor
Author
There was a problem hiding this comment.
previously anything we store as ZonedDateTime will work. But effectively it was only Date values.
Returning Date as ZonedDateTime is completely incorrect because date values do not have time part and timezone.
chernser
commented
Feb 1, 2026
| @Override | ||
| public LocalDate getLocalDate(int index) { | ||
| ClickHouseColumn column = schema.getColumnByIndex(index); | ||
| switch(column.getEffectiveDataType()) { |
Contributor
Author
There was a problem hiding this comment.
Only Date and DateTime values were stored as ZonedDateTime - so nothing changed but Date value conversion to LocalDate is not needed.
chernser
commented
Feb 1, 2026
| @Override | ||
| public LocalDate getLocalDate(int index) { | ||
| return getLocalDate(schema.columnIndexToName(index)); | ||
| public LocalTime getLocalTime(int index) { |
Contributor
Author
There was a problem hiding this comment.
New method in the interface.
Only types with time component are converted.
chernser
commented
Feb 1, 2026
| } | ||
| } else { | ||
| /// shortcut | ||
| if (type == Timestamp.class) { |
Contributor
Author
There was a problem hiding this comment.
we taking a shortcut here. Next we need to refactor conversion code to make it less complex and more context aware.
client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
| ZonedDateTime dateTime = (ZonedDateTime) value; | ||
| return dateTime.toInstant(); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Missing LocalDate handling in objectToInstant causes inconsistency
Medium Severity
The objectToInstant() helper method handles LocalDateTime and ZonedDateTime but not LocalDate. This creates an inconsistency: calling getInstant() on a regular Date/Date32 column works (lines 672-675 convert via date.atStartOfDay()), but calling getInstant() on a Dynamic/Variant column containing a Date value throws an exception because objectToInstant() returns null for LocalDate. The helper is missing a LocalDate branch that mirrors the regular column handling.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes
Checklist
Delete items not relevant to your PR:
Note
Medium Risk
Medium risk because it changes the runtime types returned for
Date/Timecolumns (and their string/JDBC conversions), including a behavior change whereDateis no longer exposed asZonedDateTime, which can break downstream code relying on prior conversions.Overview
Client-v2 now decodes
Date/Date32asLocalDate(timezone-free) andTime/Time64as UTC-backedLocalDateTime, with newgetLocalTime()accessors and updatedgetString()/temporal getters to route through the appropriate typed value (includingDynamic/Variantcoercions).Adds
ClickHouseColumn.getEffectiveDataType()to consistently unwrapSimpleAggregateFunctioncolumns for conversion logic, improves null-handling for several getters (arrays, geo, inet, duration, enums), and updates the binary reader to emit the new date/time representations.JDBC v2 updates
ResultSetdate/time conversions to useLocalDateforDateandLocalDateTimeforTime, adds agetObject()shortcut forDate/Time/Timestamp, and extendsJdbcUtilsconversions (includingDurationfrom time values).Integration tests were added/updated to validate
Date/Timebehavior across time zones and support reading date/time values fromDynamic/Variant(plus refactoring/renaming of some JDBC tests).Written by Cursor Bugbot for commit b23d218. This will update automatically on new commits. Configure here.