fix #528 Error while extract schema#534
Closed
den-crane wants to merge 1 commit intoClickHouse:developfrom
Closed
Conversation
Contributor
|
Thanks @den-crane for fixing the issue. I noticed quite some bugs related to SQL parsing, so I'd suggest to use antlr4 instead. Meanwhile, I like the idea of creating a short-term workaround. Can we avoid using regular expression and try this approach instead for better performance? |
Contributor
|
I added an experimental parser in #563 and hopefully it can fix this kind of issue. I'll merge your tests and do more testing in the next following days. |
Contributor
|
Test cases are merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #528
added support for queries with fromUnixTimestamp64Milli :
/*qq*/ SELECT fromUnixTimestamp64Milli(time)from table