Retry for NoHttpResponseException #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhicwu
changed the title
This was
linked to
issues
Jan 11, 2021
ebyhr
added a commit
to ebyhr/trino
that referenced
this pull request
Nov 16, 2021
Version 0.2.6 contains retry mechanism for NoHttpResponseException. The default retry attempt is 3. ClickHouse/clickhouse-java#540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate comment and fix #462.
This is basically opposite of HTTPCLIENT-989. Why? HTTP method
POSTis not idempotent, but when we use it to issue query, it is. In the case server closed connection, instead of throwing NoHttpResponseException, it's definitely worthy of retry by resending the request(query, not mutation or DDL).