Skip to content

when parsedStmt isDDL,Database is should not ignore#668

Closed
xj20305 wants to merge 1 commit intoClickHouse:masterfrom
xj20305:master
Closed

when parsedStmt isDDL,Database is should not ignore#668
xj20305 wants to merge 1 commit intoClickHouse:masterfrom
xj20305:master

Conversation

@xj20305
Copy link

@xj20305 xj20305 commented Jun 7, 2021

if we ignore the Database,Explicit assignment database name in sql is in need,That maybe unreasonable.
DDL语句需要注入数据库名
sql example:
String sql="ALTER TABLE HITS02 ADD COLUMN Added1 UInt32 FIRST";

if we ignore the Database,Explicit assignment database name in sql is in need,That  maybe unreasonable.
DDL语句需要注入数据库名
sql example:
String sql="ALTER TABLE HITS02 ADD COLUMN Added1 UInt32 FIRST";
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

Benchmark                           (client)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20   258.353 ±  24.389  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20   256.262 ±  27.262  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  1447.770 ± 221.947  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20  1515.347 ± 239.347  ops/s

@zhicwu
Copy link
Contributor

zhicwu commented Jun 7, 2021

Hi @xj20305, did you try latest code on develop branch?

@xj20305
Copy link
Author

xj20305 commented Jun 7, 2021

Hi @xj20305, did you try latest code on develop branch?
Hello,zhicwu
when i use version clickhouse-jdbc-0.3.1.jar I find this problem,
I try it in master last friday,and fix it here , it work well in my project.

@zhicwu
Copy link
Contributor

zhicwu commented Jun 7, 2021

Thanks @xj20305. The issue has been fixed in PR #651. 0.3.1-patch will be available shortly.

@zhicwu zhicwu closed this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants