Skip to content

Conversation

@buremba
Copy link
Contributor

@buremba buremba commented Jul 30, 2021

It looks like the log level is INFO for the driver registration. If you look at most JDBC implementations, they use DEBUG in this exact case since the registration is expected when we load ClickhouseDriver in the runtime.

@github-actions
Copy link

Benchmark                           (client)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20   259.206 ±  30.530  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20   261.069 ±  27.115  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  1433.024 ± 203.160  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20  1572.552 ± 240.538  ops/s

@zhicwu zhicwu changed the base branch from master to develop July 30, 2021 09:49
@buremba
Copy link
Contributor Author

buremba commented Aug 13, 2021

@zhicwu any ideas on why the tests are failing?

@zhicwu
Copy link
Contributor

zhicwu commented Aug 13, 2021

@zhicwu any ideas on why the tests are failing?

I think it's unrelated. I have a large PR on hand, let me merge this one over the weekend.

@zhicwu zhicwu merged commit a5666f7 into ClickHouse:develop Aug 15, 2021
@buremba
Copy link
Contributor Author

buremba commented Aug 16, 2021

Thanks @zhicwu !

@buremba
Copy link
Contributor Author

buremba commented Nov 2, 2021

Hey @zhicwu, I see that latest patch version doesn't include this PR. Is there any timeline on when can we publish this?

@zhicwu
Copy link
Contributor

zhicwu commented Nov 2, 2021

Hey @zhicwu, I see that latest patch version doesn't include this PR. Is there any timeline on when can we publish this?

It will be released together with 0.3.2. Sorry it's a complete rewrite (unfortunately), so I don't have an exact ETA - maybe a few more weeks?

As to this specific issue, perhaps you can update logging configuration by changing log level for ru.yandex.clickhouse to ERROR? FYI, starting from 0.3.2, transaction APIs like commit(), rollback() and setSavepoint() etc. will be supported, and there'll be annoying warnings keep saying it's fake transaction. Faking transaction support can be turned off for sure, but still I think changing log level to ERROR is a better solution.

@buremba
Copy link
Contributor Author

buremba commented Nov 3, 2021

OK, thanks for letting me know @zhicwu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants