🐛 fix: Move useEffect before conditional return in AppLayout#41
Merged
danny-avila merged 1 commit intoClickHouse:mainfrom May 3, 2026
Merged
Conversation
|
|
The `useEffect` hook was called after a conditional early return, violating React's Rules of Hooks. Moved `toggleSidebar` and its `useEffect` above the `AccessDenied` guard so hooks are always called in the same order. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chemsseddine
force-pushed
the
fix/hooks-order-app-layout
branch
from
14acc1d to
2998ff8
Compare
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
danny-avila
approved these changes
May 3, 2026
Contributor
|
thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
useEffecthook was called after a conditional early return, violating React's Rules of Hooks. MovedtoggleSidebarand itsuseEffectabove theAccessDeniedguard so hooks are always called in the same order.Summary
Please provide a brief summary of your changes and the related issue. Include any motivation and context that is relevant to your changes. If there are any dependencies necessary for your changes, please list them here.
Change Type
Please delete any irrelevant options.
Testing
Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.
Test Configuration:
Checklist
Please delete any irrelevant options.