Use bleak-retry-connector
#82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces manual Bluetooth Low Energy connection handling with the bleak-retry-connector library to improve connection reliability and built-in retry logic for the SkyKettle integration, addressing issue #81.
Key changes:
- Replaced manual
BleakClientconnection withestablish_connectionusingBleakClientWithServiceCache - Removed manual timeout handling (
asyncio.wait_forwrapper andCONNECTION_TIMEOUTconstant) - Simplified connection logic by leveraging built-in retry functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Merged, thank you! |
Contributor
Author
|
@ClusterM Все-таки предложение Copilot добавить |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81