fix(go-runner): do not delete the profile folder #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-matthias
requested review from
GuillaumeLagrange,
adriencaccia and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug where the profile folder was being deleted at the start of benchmark runs, which removed important profiling files like perf.pipedata that are needed for generating flamegraphs.
Key Changes:
- Conditionally remove the profile directory only in test mode using
#[cfg(test)] - Added clarifying comment explaining why the directory should not be removed in production
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This broke flamegraphs, because we removed the perf.pipedata file which is directly written to the profile folder.
not-matthias
force-pushed
the
cod-1664-e2e-golang-benchmark-doesnt-have-flamegraph
branch
from
4fe5f35 to
b3fc97c
Compare
CodSpeed Performance ReportMerging #34 will not alter performanceComparing Summary
|
not-matthias
deleted the
cod-1664-e2e-golang-benchmark-doesnt-have-flamegraph
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke flamegraphs, because we removed the perf.pipedata file which is directly written to the profile folder.