Skip to content

Conversation

@not-matthias
Copy link
Member

No description provided.

@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch from 98faf96 to 7ce4f26 Compare August 27, 2025 16:58
Base automatically changed from cod-1173-build-golang-tests-with-codspeed-instrumentation-in-runner to main August 28, 2025 08:17
@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch from 1817bda to fcfe76d Compare August 28, 2025 10:34
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 28, 2025

CodSpeed Performance Report

Merging #7 will create unknown performance changes

Comparing cod-1273-support-perf-in-golang (aa4b9f5) with main (3cc5268)

Summary

🆕 18 new benchmarks
⁉️ 10 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 fibonacci(10) N/A 560 ns N/A
🆕 BenchmarkFibonacci20_Loop N/A 107 µs N/A
🆕 BenchmarkFibonacci20_bN N/A 69 µs N/A
🆕 BenchmarkSleep100ns N/A 231 ns N/A
🆕 BenchmarkSleep100ns_Loop N/A 1 µs N/A
🆕 BenchmarkSleep100us N/A 100.1 µs N/A
🆕 BenchmarkSleep100us_Loop N/A 100.7 µs N/A
🆕 BenchmarkSleep10ms N/A 10 ms N/A
🆕 BenchmarkSleep10ms_Loop N/A 10 ms N/A
🆕 BenchmarkSleep10us N/A 10.1 µs N/A
🆕 BenchmarkSleep10us_Loop N/A 10.5 µs N/A
🆕 BenchmarkSleep1ms N/A 1 ms N/A
🆕 BenchmarkSleep1ms_Loop N/A 1 ms N/A
🆕 BenchmarkSleep1us N/A 1.1 µs N/A
🆕 BenchmarkSleep1us_Loop N/A 1.8 µs N/A
🆕 BenchmarkSleep50ms N/A 50 ms N/A
🆕 BenchmarkSleep50ms_Loop N/A 50 ms N/A
🆕 BenchmarkExample N/A < 1 ns N/A
⁉️ fibonacci(10) 549 ns N/A N/A
⁉️ BenchmarkFibonacci20_Loop 69.3 µs N/A N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch 4 times, most recently from ceaf106 to 13868da Compare August 29, 2025 12:59
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was an issue with the instrument-hooks submodule or is it expected? Files are committed in this repo

@not-matthias
Copy link
Member Author

not-matthias commented Aug 29, 2025

I think there was an issue with the instrument-hooks submodule or is it expected?

Oops, I rebased the changes into that commit but forgot to change the commit message. I ended up copying the dist artifacts because Golang doesn't fetch the git submodules within packages. I'll update it.

@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch from 13868da to 3abf563 Compare August 29, 2025 14:24
@not-matthias not-matthias requested a review from art049 August 29, 2025 14:26
@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch from 3abf563 to 04b47fc Compare August 29, 2025 14:29
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !
It would be better to merge this when the reports actually contain the flamegraphs, just so we're sure everything works

After https://github.com/CodSpeedHQ/codspeed/pull/1393

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@not-matthias
Copy link
Member Author

Looks good to me ! It would be better to merge this when the reports actually contain the flamegraphs, just so we're sure everything works

After CodSpeedHQ/codspeed#1393

Sounds good, I think I'll also add some logic to the go-runner integration tests to always fetch the codspeed-go package of the current branch when running in CI, cause otherwise I'll have no way to merge this PR when removing the last commit.

@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch 5 times, most recently from cab3584 to 2704cd1 Compare September 1, 2025 13:45
This is needed so that the runner is able to dump the symbols of the benchmark process. It also makes it easier testable as we can run the binary without go-runner at a later point.
@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch 2 times, most recently from 14a0b1b to 7aa04e5 Compare September 2, 2025 09:02
@not-matthias not-matthias requested a review from art049 September 2, 2025 09:09
@not-matthias
Copy link
Member Author

not-matthias commented Sep 2, 2025

@art049 Perf works: https://codspeed.io/CodSpeedHQ/codspeed-go/runs/68b6b3b6a013ab1b66caea43 (run of one of the stacked branch)

@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch from 7aa04e5 to 71ed90d Compare September 2, 2025 09:21
@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch from b20d439 to aa4b9f5 Compare September 2, 2025 16:56
@not-matthias not-matthias merged commit aa4b9f5 into main Sep 2, 2025
9 of 10 checks passed
@not-matthias not-matthias deleted the cod-1273-support-perf-in-golang branch September 2, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants