-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add perf support #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
98faf96 to
7ce4f26
Compare
1817bda to
fcfe76d
Compare
CodSpeed Performance ReportMerging #7 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
ceaf106 to
13868da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was an issue with the instrument-hooks submodule or is it expected? Files are committed in this repo
Oops, I rebased the changes into that commit but forgot to change the commit message. I ended up copying the dist artifacts because Golang doesn't fetch the git submodules within packages. I'll update it. |
13868da to
3abf563
Compare
3abf563 to
04b47fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me !
It would be better to merge this when the reports actually contain the flamegraphs, just so we're sure everything works
After https://github.com/CodSpeedHQ/codspeed/pull/1393
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Sounds good, I think I'll also add some logic to the go-runner integration tests to always fetch the |
cab3584 to
2704cd1
Compare
This is needed so that the runner is able to dump the symbols of the benchmark process. It also makes it easier testable as we can run the binary without go-runner at a later point.
14a0b1b to
7aa04e5
Compare
|
@art049 Perf works: https://codspeed.io/CodSpeedHQ/codspeed-go/runs/68b6b3b6a013ab1b66caea43 (run of one of the stacked branch) |
7aa04e5 to
71ed90d
Compare
b20d439 to
aa4b9f5
Compare
No description provided.