Skip to content

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Aug 28, 2025

  • Renamed simpleDeps to TestDeps (like it's done in the testing/internal/testdeps/deps.go file)
  • Add comment to clarify where this comes from
  • Implement MatchString to be able to filter benchmarks

@not-matthias not-matthias requested a review from art049 August 28, 2025 13:17
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 28, 2025

CodSpeed Performance Report

Merging #8 will not alter performance

Comparing cod-1271-benchmark-filter-doesnt-work (3cc5268) with main (4f8413e)

Summary

✅ 10 untouched benchmarks

Copy link

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as much as my go knowledge allows me to say so

@art049 art049 requested a review from Copilot September 1, 2025 13:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements proper benchmark filtering support in the Go runner by adding a functional MatchString method to the TestDeps implementation. The changes rename the previous simpleDeps struct to TestDeps to align with Go's standard testing package naming conventions and implement regex-based pattern matching for benchmark filtering.

Key changes:

  • Replaced simpleDeps with TestDeps struct that properly implements the testDeps interface
  • Added functional MatchString method with regex compilation and caching for benchmark filtering
  • Removed debug code and cleaned up formatting across both files

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
go-runner/src/builder/template.go Template file updated with TestDeps implementation and MatchString functionality
example-codspeed/cli/runner.go Example runner updated to use new TestDeps structure and removed debug output

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@not-matthias not-matthias force-pushed the cod-1271-benchmark-filter-doesnt-work branch 2 times, most recently from dc35ea0 to 1d1cb4e Compare September 1, 2025 13:30
@not-matthias not-matthias force-pushed the cod-1271-benchmark-filter-doesnt-work branch from 1d1cb4e to daeca9a Compare September 1, 2025 13:42
@not-matthias not-matthias force-pushed the cod-1271-benchmark-filter-doesnt-work branch from daeca9a to 3cc5268 Compare September 1, 2025 13:44
@not-matthias not-matthias merged commit 3cc5268 into main Sep 1, 2025
10 checks passed
@not-matthias not-matthias deleted the cod-1271-benchmark-filter-doesnt-work branch October 22, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants