-
Notifications
You must be signed in to change notification settings - Fork 0
fix(go-runner): implement MatchString testdep
#8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #8 will not alter performanceComparing Summary
|
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, as much as my go knowledge allows me to say so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements proper benchmark filtering support in the Go runner by adding a functional MatchString method to the TestDeps implementation. The changes rename the previous simpleDeps struct to TestDeps to align with Go's standard testing package naming conventions and implement regex-based pattern matching for benchmark filtering.
Key changes:
- Replaced
simpleDepswithTestDepsstruct that properly implements thetestDepsinterface - Added functional
MatchStringmethod with regex compilation and caching for benchmark filtering - Removed debug code and cleaned up formatting across both files
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| go-runner/src/builder/template.go | Template file updated with TestDeps implementation and MatchString functionality |
| example-codspeed/cli/runner.go | Example runner updated to use new TestDeps structure and removed debug output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dc35ea0 to
1d1cb4e
Compare
1d1cb4e to
daeca9a
Compare
daeca9a to
3cc5268
Compare
simpleDepstoTestDeps(like it's done in thetesting/internal/testdeps/deps.gofile)MatchStringto be able to filter benchmarks