Skip to content

Conversation

@adriencaccia
Copy link
Member

@adriencaccia adriencaccia commented Jul 31, 2023

  • feat(benchmark.js-plugin): support setup and teardown

@adriencaccia adriencaccia requested a review from art049 July 31, 2023 15:40
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 31, 2023

CodSpeed Performance Report

Merging #21 will improve performances by 42.47%

Comparing feat/benchmark.js-hooks (03de0f0) with main (cd532fd)

Summary

🔥 2 improvements
✅ 62 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/benchmark.js-hooks Change
🔥 test async baz 100 1.8 ms 1.3 ms +42.47%
🔥 test async baz 100 1.9 ms 1.4 ms +39.22%

@adriencaccia
Copy link
Member Author

make sure that beforeEach and afterEach hooks are run around the optimize function call in both plugins

@adriencaccia adriencaccia force-pushed the feat/benchmark.js-hooks branch from 07d041e to 4264561 Compare August 2, 2023 12:53
@adriencaccia
Copy link
Member Author

make sure that beforeEach and afterEach hooks are run around the optimize function call in both plugins

done in #23

@adriencaccia adriencaccia force-pushed the feat/benchmark.js-hooks branch from 4264561 to 03de0f0 Compare August 3, 2023 08:24
@adriencaccia adriencaccia merged commit 03de0f0 into main Aug 3, 2023
@adriencaccia adriencaccia deleted the feat/benchmark.js-hooks branch August 3, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants