fix: bugs in walltime command #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-matthias
requested review from
GuillaumeLagrange,
adriencaccia and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR fixes working directory handling and error propagation in the perf runner for wall-time benchmarking. The changes ensure that commands wrapped with perf profiling execute in the correct working directory, and that pipeline failures are properly detected.
- Added
set -o pipefailto the shell command to ensure pipeline failures are caught - Preserved working directory when wrapping commands for perf profiling
- Added comprehensive tests for working directory handling and failure detection
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/run/runner/helpers/command.rs |
Added get_current_dir() getter method to expose the working directory from CommandBuilder |
src/run/runner/wall_time/perf/mod.rs |
Added set -o pipefail to shell command and preserved working directory when wrapping commands for perf |
src/run/runner/tests.rs |
Added tests for working directory preservation and command failure detection with both perf enabled and disabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
not-matthias
force-pushed
the
cod-1652-error-no-walltime-data-found-in-processed-report
branch
from
54390a2 to
3bf0cff
Compare
adriencaccia
approved these changes
Nov 10, 2025
not-matthias
deleted the
cod-1652-error-no-walltime-data-found-in-processed-report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.