fix: filter out empty named symbols when building perf-map #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-matthias
approved these changes
Dec 18, 2025
There was a problem hiding this comment.
Pull request overview
This PR enhances the symbol filtering logic in the perf-map builder to exclude symbols with empty names in addition to the existing filter for zero-size symbols. This prevents invalid or unnamed symbols from being included in the performance mapping output.
Key changes:
- Extended symbol filtering to exclude both zero-size symbols and empty-named symbols
- Added trace logging for filtered symbols to aid debugging
- Improved the comment describing the filtering behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GuillaumeLagrange
force-pushed
the
fix-filter-out-empty-symbols
branch
from
cd7d6ee to
984fc10
Compare
GuillaumeLagrange
force-pushed
the
fix-filter-out-empty-symbols
branch
from
984fc10 to
fdf53e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.