Skip to content

Conversation

@GuillaumeLagrange
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange commented Dec 22, 2025

Fixes the end to end tests (and the walltime flamegraph on macro runners as well 😬)

We used to transparently filter out these symbosl because they are 0-sized. However, we do not filter out zero-sized symbols now, but were not handling these special symbols properly

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1895-e2e-integration-tests-not-passing-since-friday branch from 7c2eea4 to 81152ee Compare December 22, 2025 14:49
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1895-e2e-integration-tests-not-passing-since-friday branch from 81152ee to 5ead644 Compare December 22, 2025 14:50
Copy link
Member

@adriencaccia adriencaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, on the condition it indeed fixes the flamegraph of the e2e tests

@GuillaumeLagrange GuillaumeLagrange merged commit 5ead644 into main Dec 22, 2025
9 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-1895-e2e-integration-tests-not-passing-since-friday branch December 22, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants