#A03. As Admin, I would like to update existing Hackathon events.#106
Conversation
…ow selecting past date for start date
… or in progress hackathons
…rectly in edit form
stefdworschak
left a comment
There was a problem hiding this comment.
LGTM
@hebs87 please have a quick look at my comments and let me know when I can merge it.
hackathon/views.py
Outdated
There was a problem hiding this comment.
Don't think you need to declare the template, you can just pass it directly in the render function
There was a problem hiding this comment.
This is just a personal preference, but if the preference here is to pass it in directly then that's cool. I've made the change, it'll be visible when I push it to the existing PR 👍
hackathon/views.py
Outdated
There was a problem hiding this comment.
Please remove the unneeded blank line
There was a problem hiding this comment.
Done, this will be visible when I push the change to the existing PR.
hackathon/urls.py
Outdated
There was a problem hiding this comment.
This line is too long as per PEP8 it should be less than 79 chars. Please make sure that all of the lines/files adhere to this.
There was a problem hiding this comment.
Done, this will be visible once I push the changes to the existing PR.
hackathon/views.py
Outdated
There was a problem hiding this comment.
Can you please remove the pass (this is not required) and the unneeded blank line above?
There was a problem hiding this comment.
Done. This will be visible once I push the changes to the existing PR.
User Story ID:
Description of PR:
All changes made are outlined below:
Tests:
Manually tested all implemented functionality, which is all working as expected.
Validated all code in relevant validators and all passed - HTML validator threw errors for Django template tags, but no other errors.
Know bugs/errors:
No known bugs or errors after testing.
Screenshots:
Does this introduce a breaking change