Skip to content

Gbrachetta#121

Merged
stefdworschak merged 3 commits intoCode-Institute-Community:masterfrom
GBrachetta:gbrachetta
Dec 28, 2020
Merged

Gbrachetta#121
stefdworschak merged 3 commits intoCode-Institute-Community:masterfrom
GBrachetta:gbrachetta

Conversation

@GBrachetta
Copy link
Contributor

Description

This adds:

  • Missing dj-database-url dependency and import for correct functioning of Postgres dbs.
  • Missing jQuery-ui import for otherwise non-functional accordion.

Pull request type

Related Issue

Configuration instructions

Testing

Screenshots

Additional Information

  • dj-database-url is a required dependency to make possible the communication between the app and a Postgres database. The configuration invoked it but the dependency was missing and not imported.
  • the script.js file includes a call to .accordion() which is not included in jQuery and needs the additional jQuery-ui for it to work. It was throwing a console error.

Does this introduce a breaking change

  • Yes
  • No

Copy link
Member

@stefdworschak stefdworschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefdworschak stefdworschak merged commit d902a98 into Code-Institute-Community:master Dec 28, 2020
@GBrachetta GBrachetta deleted the gbrachetta branch December 28, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments