#M14. Misc cleanup changes and improvements#148
Merged
stefdworschak merged 23 commits intoCode-Institute-Community:masterfrom Feb 15, 2021
Merged
#M14. Misc cleanup changes and improvements#148stefdworschak merged 23 commits intoCode-Institute-Community:masterfrom
stefdworschak merged 23 commits intoCode-Institute-Community:masterfrom
Conversation
…ommunity/ci-hackathon-app into f-custom-slack-provider
TravelTimN
approved these changes
Feb 11, 2021
Collaborator
TravelTimN
left a comment
TravelTimN
left a comment
There was a problem hiding this comment.
In addition to the small fix below related to team_size everywhere... I saw some other bits last night on the demo that should be consistent:
https://github.com/Code-Institute-Community/ci-hackathon-app/blob/master/accounts/lists.py#L26
Python Essentials with capital E to match the others.
This is listed in two migration files as well, so will just need a new migration. I'd imagine.
Other than those tiny fixes, LGTM! 👍🏻
TravelTimN
approved these changes
Feb 11, 2021
Collaborator
TravelTimN
left a comment
TravelTimN
left a comment
There was a problem hiding this comment.
LGTM with a few notes below.
Member
Author
|
@TravelTimN thanks for the review. Additionally to all of the changes mentioned I added a new migration for the adjusted model choice for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
hack_in_progressstatusjudging_statusfrom hackathon as no longer neededformat_datefunction to correctly parse datesPull request type
Related Issue
#131
Testing
Some tests failing locally