Skip to content

Pull request template#73

Merged
stefdworschak merged 8 commits intomasterfrom
pull-request-template-2
Oct 18, 2020
Merged

Pull request template#73
stefdworschak merged 8 commits intomasterfrom
pull-request-template-2

Conversation

@stefdworschak
Copy link
Member

Description:
Adding a template for Pull Requests with suggested headings to simplify the process of creating a new Pull Request.

@TravelTimN
Copy link
Collaborator

@stefdworschak are you waiting for me on this one?

@stefdworschak
Copy link
Member Author

Yep. Please review and if you're okay with it approve it.

Copy link
Collaborator

@TravelTimN TravelTimN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammatical adjustments, and then the end of the file seems to be missing on the forking.md.

@stefdworschak
Copy link
Member Author

stefdworschak commented Oct 17, 2020

@TravelTimN thanks for reviewing. Could you please have another look? I added the rest of the forking instructions. Also, the images are linked already, but will only be working once the PR is merged as I have added the link to where the files will be on master.

Copy link
Collaborator

@TravelTimN TravelTimN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefdworschak stefdworschak merged commit 366143f into master Oct 18, 2020
@stefdworschak stefdworschak deleted the pull-request-template-2 branch October 18, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments