#P04 As Participant, I would like to see a list of any upcoming Hackathons.#76
Conversation
Created hackathon app and moved tests inside its own module.
Updating branch with base files.
Connected the "hackathon" app by urls and settings"
Foregin Key fields will be revised as other models are created.
Added to admin. Minor adjustment made to Hackathon related name field
Updated comments. Must update all FK fields.
Foreign Keys match the schema closely but need review. See comments.
Syncing with changes from upstream repo
Sitched the *-Link fields for URLFields. Added comments.
Sitched the *-Link fields for URLFields. Added comments. Added URLFields to project Model Changed *_link to URLField, added comments. This commit fixes issue #61
…to m05 Updating commits to append request to issue.
Should not be commited here.
…to m05 Merging deletion of settings.json
…to m05 Consolidating an amend.
Also Changed model field name for readability.
…to m05 Merging with latest updates
Wired up a basic listview with a template. To fix issue #21
Basic model setup and page status and rendering test added.
Created a a basic layout page and a card include snippet.
Updated color and font-family
View now paginates Django using default context_obj terms.
The paginator can now be used as a template in other pages.
Primary color applied to links.
stefdworschak
left a comment
stefdworschak
left a comment
There was a problem hiding this comment.
LGTM
@Ri-Dearg looks great. Just finish up the few minor changes and I will merge it.
hackathon/tests/test_views.py
Outdated
| def setUp(self): | ||
| """Sets up the models for testing""" | ||
| user = User.objects.create(username="testuser") | ||
| user.save() |
There was a problem hiding this comment.
I think you can remove user.save(). The model is saved automatically when you call create(). Might have overlooked that in your previous tests. If you have used the same there you can go back in another PR and change that as well.
static/css/style.css
Outdated
|
|
||
| /* TEXT */ | ||
| .p-orange { | ||
| color: var(--p-orange); |
There was a problem hiding this comment.
Make sure you keep the indentation level consistend (4 spaces). Please adjust for anything below as well
There was a problem hiding this comment.
I'll go fix that up now
| <h6 class="card-subtitle mb-2 text-muted">{{ hackathon.start_date }} - {{ hackathon.end_date }}</h6> | ||
| <p class="card-text">{{ hackathon.description }}</p> | ||
| {% if hackathon.organiser %} | ||
| <p>Organiser: <a href="#" class="p-blue card-link">{{ hackathon.organiser }}</a></p> |
There was a problem hiding this comment.
Not sure if we need to show the organiser, but let's leave it for the moment.
There was a problem hiding this comment.
Yeah, I thought it could be handy if people had public-facing profiles. It might not be so useful otherwise.
| @@ -0,0 +1,18 @@ | |||
| <ul class="pagination justify-content-center"> | |||
| {% if page_obj.has_previous %} | |||
There was a problem hiding this comment.
This is a really cool solution for pagination!
|
Actually, just saw it's only a draft. But I'd say we can merge it already and you can work on the other pages in another PR. |
Ri-Dearg
left a comment
Ri-Dearg
left a comment
There was a problem hiding this comment.
Format changes made for style.css and removed .save().
|
@Ri-Dearg looks great! Merging now. |
2 participants
Hiya! I have a draft to fix issue #21 ready to go.
Description
includetemplate using the defaultpage_obj, so it is modular, allowing use for other paginated lists.style.cssfor the cards, the paginator and text colors.Tests
Known Bugs
None I can find, the view keeps it simple! 😃
Let me know what ye think, what yere vision is, I'll put in the additions to fix it right up!
Screenshots
