#B01 Fixed bug with setup.bat not setting global server on .env#82
Merged
stefdworschak merged 1 commit intoCode-Institute-Community:masterfrom Oct 18, 2020
Merged
Conversation
Contributor
Author
|
@stefdworschak Look ok? |
TravelTimN
added
hacktoberfest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup.bat file for setting up environment for Windows IDE's was populating the SITE_NAME with 'localhost' which would not work on a local environment, as the IP would be 127.0.0.1. However, using this would conflict with those using Cloud based IDE like Gitpod.
Fixed error by changing the SITE_NAME="*" to set globally.