Skip to content

PR / Issue automation - Better setup script#85

Merged
stefdworschak merged 17 commits intoCode-Institute-Community:masterfrom
Eventyret:feature/pull-and-issue-request-automation
Oct 20, 2020
Merged

PR / Issue automation - Better setup script#85
stefdworschak merged 17 commits intoCode-Institute-Community:masterfrom
Eventyret:feature/pull-and-issue-request-automation

Conversation

@Eventyret
Copy link
Contributor

Description:

  • Changed ISSUE_TEMPLATE for GitHub (adding comments instead of just text, saving people from removing test)
  • Added ISSUE_TEMPLTE for Pull Requests (Standard info so feel free to tweak or make comments to this)
  • Removed files that were not needed
  • setup.sh and setup.bat will not install the python extensions for Vscode (Requires reload of VSCode)
  • setup.sh will now check if Pipfile is present if it is it will use this (saves time) if not falls back to requirements.
  • setup.sh and setup.bat will now install pylint pylint-django pep8 autopep8 this should help with Vscode and lining issues for best Pep8 practices
  • setup.sh and setup.bat will now create a vscode/settings.json this to hold linting info and also should auto-detect if a virtual environment is selected
  • Pipenv is included and should not be excluded (this will be like a requirements.txt) and will help with pipenv for those using VSCode (Heroku also supports it)

Related Issue:

N/A

Configuration instructions:

N/A

Screenshots:
UI

Additional Information:
Would love some help with the bat and convert it I'm on mac so unable to test setup.bat feel free to make a PR towards this or use what has been generated and modify accordingly.

@Eventyret Eventyret changed the title Feature/pull and issue request automation PR / Issue automation - Better setup script Oct 20, 2020
Copy link
Member

@stefdworschak stefdworschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefdworschak stefdworschak merged commit f075566 into Code-Institute-Community:master Oct 20, 2020
@Eventyret Eventyret deleted the feature/pull-and-issue-request-automation branch October 20, 2020 11:46
@Eventyret
Copy link
Contributor Author

@JimLynx if you want to for the bat file do let me know and we can have a session and fun.

@JimLynx
Copy link
Contributor

JimLynx commented Oct 20, 2020

That would be super @Eventyret

@Eventyret
Copy link
Contributor Author

@TravelTimN Would this go towrds the accepted tag for Hacktober please ?

@TravelTimN TravelTimN added the hacktoberfest-accepted Accepted PR during Hacktoberfest label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted PR during Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments