Refactor Bot Lifecycle and Event Synchronization#39
Merged
PenguinBoi12 merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
534ab96 to
b81eb2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Botlifecycle to clearly separate synchronization and readiness:Previously, scheduled tasks or extensions could attempt to access bot state before rooms were available, leading to crashes. The new lifecycle ensures predictable ordering: sync → ready → scheduler, improving reliability and making asynchronous tests non-blocking.
_synced(asyncio.Event) to track when the client has completed initial syncing._wait_until_syncednow waits for the first sync before firingon_ready.on_readyis guaranteed to run once, after the bot is fully synchronized, before scheduled tasks are started.get_roomupdated to returnNoneinstead of raising, preventing crashes during startup.sync_forever, by setting_syncedmanually and mocking long-running tasks.