Fix Routing Command Errors Through _on_command_error Instead of _on_error#42
Merged
PenguinBoi12 merged 1 commit intomainfrom Apr 12, 2026
Merged
Fix Routing Command Errors Through _on_command_error Instead of _on_error#42PenguinBoi12 merged 1 commit intomainfrom
_on_command_error Instead of _on_error#42PenguinBoi12 merged 1 commit intomainfrom
Conversation
PenguinBoi12
changed the title
_on_command_error Instead of _on_error_on_command_error Instead of _on_error
PenguinBoi12
force-pushed
the
fix-error-handler
branch
from
92dcf3c to
5442e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command errors were bubbling up through
_on_matrix_event's generic try/except, routing them to_on_errorinstead of_on_command_error. Fixed by wrapping_process_commandsin a try/except that catches all command-related errors and dispatches them through theon_command_errorlifecycle hook, which has access to context.