Filtered Processes #177
Merged
Filtered Processes #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@eajhnsn1 thank you for your PR and my apologies that it took so long to get it merged and shipped! |
Contributor
Author
|
Thanks for accepting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Case
When doing a presentation, I really only want key presses to be shown if they are for specific applications, such as Visual Studio or another text editor. This will prevent passwords and other secrets from accidentally being shown as they are typed into other applications.
Proposed Solution
Add an option to the settings to allow a regular expression filter for process names to whitelist key presses from. If no filter, or an invalid regular expression is supplied, Carnac should behave as if unfiltered (ie. today's current behavior).
Notes
This is my first pull request in any repo, and I'm new to git. If this isn't the correct process or procedure, I apologize. If I should have done anything different, just let me know and I will correct it.
Thanks!