Fix site.title and page.id #186
Conversation
Now the title can be defined in _config.yml and used in the liquid template.
Now, the priority are: - page.title in the page yaml front matter - site.title in _config.yml - SiteContext.Title And add a few tests.
And the id can be defined in the page without any error but it will not be used.
|
👍 |
|
@shiftkey sorry to bother you, but is the TeamCity server working? |
|
Not sure, I'd have to ask @JakeGinnivan what's up. If you want to take charge of the CI process, I'd highly recommend AppVeyor. I don't think Jake would mind either! |
|
Nope, happy for it to change. I can also give you admin permission to the teamcity build if you want to modify that? The biggest issue with the build is that when you release it doesn't upload the zip to github, it just pushes the chocolatey package which points to a zip which has not been uploaded |
|
Build is working - http://teamcity.ginnivan.net/viewType.html?buildTypeId=bt52 Report status to github is not setup though. |
|
I'll be happy to try to modify the teamcity build. |
|
@laedit just create an account and I will set you up |
|
Done. And sorry about the failing test, I will fix it ASAP. |
|
@laedit done, you are project admin on the Pretzel project in teamcity. If you need a hand setting anything up I am more than happy to help! |
|
Weird, it seems that the GitHub report status plugin is well configured and activated but do nothing... |
|
Will try to update it tonight. |
|
The Team CIty server seems to not responding. Not a big problem, I have set up an AppVeyor project. @shiftkey there is one little problem thought, the AppVeyor do not seem to add a build in the queue for each push, could you tell me if the "push" and "pull request" trigger are checked in the repo options? |
I can only see "push" is configured - could you check the TeamCity settings and see if something is missing there? |
|
Sorry, I wasn't clear, the Team CIty server is out. |
|
@laedit ok, I've added the webhook for the AppVeyor URL |
|
@shiftkey Thanks! 😄 |
This should fix #182.
The site.title has been implemented like jekyll, but the page.id has some differences:
In Jekyll with the permalink /:categories/:year/:month/:day/:title/index.html the page id will be something like that: "/fr/2014/11/26/myfirstpost/myfirstpost".
In Pretzel it will be: "/fr/2014/11/26/myfirstpost/".
The other difference is that in Jekyll the pages have no id, only the posts have. In Pretzel both will have a generated id.
@shiftkey, @JakeGinnivan are you okay with that?