This repository was archived by the owner on Jun 25, 2020. It is now read-only.
Fix for page.url when paginating #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sorry for the silence, I was out of town for a few time. |
laedit
pushed a commit
that referenced
this pull request
Aug 4, 2015
Fix for page.url when paginating
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When paginating, currently each page gets a
PageContextinstance differing only in thePaginatorandOutputPathproperties. Especially allPageContexts share the sameBagdictionary.However, if you want to use
page.urlin your template, you always get the url of the first page, even on the successive pages. This makes it impossible to include a canonical url in the head of your HTML page.This PR changes the copy c'tor of
PageContextso that it receives a clone of the originalPageContext.Bag, and when paginating eachPageContext's bag will have its correct url property set.